Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e292dcae authored by Mahesh Bandewar's avatar Mahesh Bandewar Committed by David S. Miller
Browse files

bonding: avoid printing while holding a spinlock 



Signed-off-by: default avatarMahesh Bandewar <maheshb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b5bf0f5b

drivers/net/bonding/bond_3ad.c

+3 −3
Original line number Diff line number Diff line
@@ -2446,9 +2446,9 @@ void bond_3ad_adapter_speed_duplex_changed(struct slave *slave) 


	spin_lock_bh(&slave->bond->mode_lock);

	ad_update_actor_keys(port, false);

	spin_unlock_bh(&slave->bond->mode_lock);

	netdev_dbg(slave->bond->dev, "Port %d slave %s changed speed/duplex\n",

		   port->actor_port_number, slave->dev->name);

	spin_unlock_bh(&slave->bond->mode_lock);

}



/**
@@ -2492,12 +2492,12 @@ void bond_3ad_handle_link_change(struct slave *slave, char link) 
	agg = __get_first_agg(port);

	ad_agg_selection_logic(agg, &dummy);



	spin_unlock_bh(&slave->bond->mode_lock);



	netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n",

		   port->actor_port_number,

		   link == BOND_LINK_UP ? "UP" : "DOWN");



	spin_unlock_bh(&slave->bond->mode_lock);



	/* RTNL is held and mode_lock is released so it's safe

	 * to update slave_array here.

	 */