Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e23ed600 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: htcpen - switch to DMI-based autoloading 



Having module device table based on PNP id produces the following warning:

  CC      drivers/input/touchscreen/htcpen.o
drivers/input/touchscreen/htcpen.c:50: warning: 'pnp_ids' defined but not used

This happens because it is not a PNP driver, bit rather ISA driver and
pnp_ids table is not used anywhere. To fix this issue let's switch to
DMI-based module table instead,

Reported-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 75255b29

drivers/input/touchscreen/htcpen.c

+1 −6
Original line number Original line Diff line number Diff line
@@ -47,12 +47,6 @@ static int invert_y; 
module_param(invert_y, bool, 0644);

module_param(invert_y, bool, 0644);

MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");

MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");





static struct pnp_device_id pnp_ids[] = {

	{ .id = "PNP0cc0" },

	{ .id = "" }

};

MODULE_DEVICE_TABLE(pnp, pnp_ids);



static irqreturn_t htcpen_interrupt(int irq, void *handle)

static irqreturn_t htcpen_interrupt(int irq, void *handle)

{

{

	struct input_dev *htcpen_dev = handle;

	struct input_dev *htcpen_dev = handle;
@@ -237,6 +231,7 @@ static struct dmi_system_id __initdata htcshift_dmi_table[] = { 
	},

	},

	{ }

	{ }

};

};

MODULE_DEVICE_TABLE(dmi, htcshift_dmi_table);





static int __init htcpen_isa_init(void)

static int __init htcpen_isa_init(void)

{

{