Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e22f692f authored by Rakesh Pandit's avatar Rakesh Pandit Committed by Greg Kroah-Hartman
Browse files

lightnvm: pblk: fix changing GC group list for a line 




[ Upstream commit 27b97872 ]

pblk_line_gc_list seems to had a bug since the introduction of pblk in
getting GC list for a line. In b20ba1bc while redesigning the GC
algorithm, the naming for the GC thresholds was altered, but the
values for high_thrs and mid_thrs were not. The result is that when
moving to the GC lists, the mid threshold is never evaluated.

Fixes: a4bd217b("lightnvm: physical block device (pblk) target")
Signed-off-by: default avatarRakesh Pandit <rakesh@tuxera.com>
Signed-off-by: default avatarMatias Bjørling <m@bjorling.me>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1b07f751

drivers/lightnvm/pblk-init.c

+2 −2
Original line number Diff line number Diff line
@@ -681,8 +681,8 @@ static int pblk_lines_init(struct pblk *pblk) 
	lm->blk_bitmap_len = BITS_TO_LONGS(geo->nr_luns) * sizeof(long);

	lm->sec_bitmap_len = BITS_TO_LONGS(lm->sec_per_line) * sizeof(long);

	lm->lun_bitmap_len = BITS_TO_LONGS(geo->nr_luns) * sizeof(long);

	lm->high_thrs = lm->sec_per_line / 2;

	lm->mid_thrs = lm->sec_per_line / 4;

	lm->mid_thrs = lm->sec_per_line / 2;

	lm->high_thrs = lm->sec_per_line / 4;

	lm->meta_distance = (geo->nr_luns / 2) * pblk->min_write_pgs;



	/* Calculate necessary pages for smeta. See comment over struct