Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dde622a5 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf tests attr: Rename compare_data to data_equal 



The data_equal name fits better to the return value of the function.
It's true when the data is equal.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20170703145030.12903-6-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 04c31bcf

tools/perf/tests/attr.py

+4 −4
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ import logging 
import shutil

import ConfigParser



def compare_data(a, b):

def data_equal(a, b):

    # Allow multiple values in assignment separated by '|'

    a_list = a.split('|')

    b_list = b.split('|')
@@ -101,7 +101,7 @@ class Event(dict): 
            log.debug("      [%s] %s %s" % (t, self[t], other[t]));

            if not self.has_key(t) or not other.has_key(t):

                return False

            if not compare_data(self[t], other[t]):

            if not data_equal(self[t], other[t]):

                return False

        return True
@@ -109,7 +109,7 @@ class Event(dict): 
        for t in Event.terms:

            if not self.has_key(t) or not other.has_key(t):

                continue

            if not compare_data(self[t], other[t]):

            if not data_equal(self[t], other[t]):

		log.warning("expected %s=%s, got %s" % (t, self[t], other[t]))



# Test file description needs to have following sections:
@@ -220,7 +220,7 @@ class Test(object): 


        log.info("  '%s' ret '%s', expected '%s'" % (cmd, str(ret), str(self.ret)))



        if not compare_data(str(ret), str(self.ret)):

        if not data_equal(str(ret), str(self.ret)):

            raise Unsup(self)



    def compare(self, expect, result):