Commit dcdd54c2 authored Feb 09, 2018 by Arnd Bergmann Committed by Kalle Valo Feb 27, 2018

rtlwifi: rtl8192cu: remove pointless memcpy

gcc-8 points out that source and destination of the memcpy() are
always the same pointer, so the effect of memcpy() is undefined
here (its arguments must not overlap):

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function '_rtl_rx_process':
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:430:2: error: 'memcpy' source argument is the same as destination [-Werror=restrict]

Most likely this is harmless, but it's easy to just remove the
line and get rid of the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent fb239c12

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -427,7 +427,6 @@ static void _rtl_rx_process(struct ieee80211_hw hw, struct sk_buff skb)
		(u32)hdr->addr1[0], (u32)hdr->addr1[1],
		(u32)hdr->addr1[2], (u32)hdr->addr1[3],
		(u32)hdr->addr1[4], (u32)hdr->addr1[5]);
		memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status));
		ieee80211_rx(hw, skb);
		}