Commit dba79f38 authored Jan 25, 2017 by Chao Yu Committed by Jaegeuk Kim Feb 22, 2017

f2fs: fix to avoid overflow when left shifting page offset



We use following method to calculate size with current page index:
size = index << PAGE_SHIFT
If type of index has only 32-bits size, left shifting will incur overflow,
which makes result incorrect.

So let's cast index with 64-bits type to avoid such issue.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent ba38c27e

fs/f2fs/recovery.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -428,8 +428,9 @@ static int do_recover_data(struct f2fs_sb_info sbi, struct inode inode,
		}

		if (!file_keep_isize(inode) &&
		(i_size_read(inode) <= (start << PAGE_SHIFT)))
		f2fs_i_size_write(inode, (start + 1) << PAGE_SHIFT);
		(i_size_read(inode) <= ((loff_t)start << PAGE_SHIFT)))
		f2fs_i_size_write(inode,
		(loff_t)(start + 1) << PAGE_SHIFT);

		/*
		* dest is reserved block, invalidate src block