Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db4723b3 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Check max_tx_scheduler_inputs value from firmware. 



When checking for the maximum pre-set TX channels for ethtool -l, we
need to check the current max_tx_scheduler_inputs parameter from firmware.
This parameter specifies the max input for the internal QoS nodes currently
available to this function.  The function's TX rings will be capped by this
parameter.  By adding this logic, we provide a more accurate pre-set max
TX channels to the user.

Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00db3cba

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+6 −2
Original line number Diff line number Diff line
@@ -5093,7 +5093,7 @@ static int bnxt_hwrm_func_qcfg(struct bnxt *bp) 
	return rc;

}



static int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp)

int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all)

{

	struct hwrm_func_resource_qcaps_output *resp = bp->hwrm_cmd_resp_addr;

	struct hwrm_func_resource_qcaps_input req = {0};
@@ -5110,6 +5110,10 @@ static int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp) 
		goto hwrm_func_resc_qcaps_exit;

	}



	hw_resc->max_tx_sch_inputs = le16_to_cpu(resp->max_tx_scheduler_inputs);

	if (!all)

		goto hwrm_func_resc_qcaps_exit;



	hw_resc->min_rsscos_ctxs = le16_to_cpu(resp->min_rsscos_ctx);

	hw_resc->max_rsscos_ctxs = le16_to_cpu(resp->max_rsscos_ctx);

	hw_resc->min_cp_rings = le16_to_cpu(resp->min_cmpl_rings);
@@ -5216,7 +5220,7 @@ static int bnxt_hwrm_func_qcaps(struct bnxt *bp) 
	if (rc)

		return rc;

	if (bp->hwrm_spec_code >= 0x10803) {

		rc = bnxt_hwrm_func_resc_qcaps(bp);

		rc = bnxt_hwrm_func_resc_qcaps(bp, true);

		if (!rc)

			bp->flags |= BNXT_FLAG_NEW_RM;

	}

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+2 −0
Original line number Diff line number Diff line
@@ -786,6 +786,7 @@ struct bnxt_hw_resc { 
	u16	min_tx_rings;

	u16	max_tx_rings;

	u16	resv_tx_rings;

	u16	max_tx_sch_inputs;

	u16	min_rx_rings;

	u16	max_rx_rings;

	u16	resv_rx_rings;
@@ -1456,6 +1457,7 @@ int bnxt_hwrm_set_pause(struct bnxt *); 
int bnxt_hwrm_set_link_setting(struct bnxt *, bool, bool);

int bnxt_hwrm_alloc_wol_fltr(struct bnxt *bp);

int bnxt_hwrm_free_wol_fltr(struct bnxt *bp);

int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all);

int bnxt_hwrm_fw_set_time(struct bnxt *);

int bnxt_open_nic(struct bnxt *, bool, bool);

int bnxt_half_open_nic(struct bnxt *bp);

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+11 −0
Original line number Diff line number Diff line
@@ -425,15 +425,26 @@ static void bnxt_get_channels(struct net_device *dev, 
			      struct ethtool_channels *channel)

{

	struct bnxt *bp = netdev_priv(dev);

	struct bnxt_hw_resc *hw_resc = &bp->hw_resc;

	int max_rx_rings, max_tx_rings, tcs;

	int max_tx_sch_inputs;



	/* Get the most up-to-date max_tx_sch_inputs. */

	if (bp->flags & BNXT_FLAG_NEW_RM)

		bnxt_hwrm_func_resc_qcaps(bp, false);

	max_tx_sch_inputs = hw_resc->max_tx_sch_inputs;



	bnxt_get_max_rings(bp, &max_rx_rings, &max_tx_rings, true);

	if (max_tx_sch_inputs)

		max_tx_rings = min_t(int, max_tx_rings, max_tx_sch_inputs);

	channel->max_combined = min_t(int, max_rx_rings, max_tx_rings);



	if (bnxt_get_max_rings(bp, &max_rx_rings, &max_tx_rings, false)) {

		max_rx_rings = 0;

		max_tx_rings = 0;

	}

	if (max_tx_sch_inputs)

		max_tx_rings = min_t(int, max_tx_rings, max_tx_sch_inputs);



	tcs = netdev_get_num_tc(dev);

	if (tcs > 1)