Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da2bbdcc authored by Harvey Harrison's avatar Harvey Harrison Committed by Greg Kroah-Hartman
Browse files

USB: avoid needless address-taking of function parameters 



There's no need to take the address of the function params or local variables
when the direct value byteswapping routines are available.

Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent aa459e6a

drivers/net/usb/kaweth.c

+3 −3
Original line number Diff line number Diff line
@@ -283,9 +283,9 @@ static int kaweth_control(struct kaweth_device *kaweth, 


	dr->bRequestType= requesttype;

	dr->bRequest = request;

	dr->wValue = cpu_to_le16p(&value);

	dr->wIndex = cpu_to_le16p(&index);

	dr->wLength = cpu_to_le16p(&size);

	dr->wValue = cpu_to_le16(value);

	dr->wIndex = cpu_to_le16(index);

	dr->wLength = cpu_to_le16(size);



	return kaweth_internal_control_msg(kaweth->dev,

					pipe,

drivers/net/usb/pegasus.c

+6 −6
Original line number Diff line number Diff line
@@ -150,8 +150,8 @@ static int get_registers(pegasus_t * pegasus, __u16 indx, __u16 size, 
	pegasus->dr.bRequestType = PEGASUS_REQT_READ;

	pegasus->dr.bRequest = PEGASUS_REQ_GET_REGS;

	pegasus->dr.wValue = cpu_to_le16(0);

	pegasus->dr.wIndex = cpu_to_le16p(&indx);

	pegasus->dr.wLength = cpu_to_le16p(&size);

	pegasus->dr.wIndex = cpu_to_le16(indx);

	pegasus->dr.wLength = cpu_to_le16(size);

	pegasus->ctrl_urb->transfer_buffer_length = size;



	usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
@@ -208,8 +208,8 @@ static int set_registers(pegasus_t * pegasus, __u16 indx, __u16 size, 
	pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;

	pegasus->dr.bRequest = PEGASUS_REQ_SET_REGS;

	pegasus->dr.wValue = cpu_to_le16(0);

	pegasus->dr.wIndex = cpu_to_le16p(&indx);

	pegasus->dr.wLength = cpu_to_le16p(&size);

	pegasus->dr.wIndex = cpu_to_le16(indx);

	pegasus->dr.wLength = cpu_to_le16(size);

	pegasus->ctrl_urb->transfer_buffer_length = size;



	usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
@@ -261,7 +261,7 @@ static int set_register(pegasus_t * pegasus, __u16 indx, __u8 data) 
	pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;

	pegasus->dr.bRequest = PEGASUS_REQ_SET_REG;

	pegasus->dr.wValue = cpu_to_le16(data);

	pegasus->dr.wIndex = cpu_to_le16p(&indx);

	pegasus->dr.wIndex = cpu_to_le16(indx);

	pegasus->dr.wLength = cpu_to_le16(1);

	pegasus->ctrl_urb->transfer_buffer_length = 1;
@@ -476,7 +476,7 @@ static inline void get_node_id(pegasus_t * pegasus, __u8 * id) 


	for (i = 0; i < 3; i++) {

		read_eprom_word(pegasus, i, &w16);

		((__le16 *) id)[i] = cpu_to_le16p(&w16);

		((__le16 *) id)[i] = cpu_to_le16(w16);

	}

}

drivers/usb/core/message.c

+3 −3
Original line number Diff line number Diff line
@@ -139,9 +139,9 @@ int usb_control_msg(struct usb_device *dev, unsigned int pipe, __u8 request, 


	dr->bRequestType = requesttype;

	dr->bRequest = request;

	dr->wValue = cpu_to_le16p(&value);

	dr->wIndex = cpu_to_le16p(&index);

	dr->wLength = cpu_to_le16p(&size);

	dr->wValue = cpu_to_le16(value);

	dr->wIndex = cpu_to_le16(index);

	dr->wLength = cpu_to_le16(size);



	/* dbg("usb_control_msg"); */

drivers/usb/gadget/net2280.c

+1 −1
Original line number Diff line number Diff line
@@ -669,7 +669,7 @@ fill_dma_desc (struct net2280_ep *ep, struct net2280_request *req, int valid) 


	/* 2280 may be polling VALID_BIT through ep->dma->dmadesc */

	wmb ();

	td->dmacount = cpu_to_le32p (&dmacount);

	td->dmacount = cpu_to_le32(dmacount);

}



static const u32 dmactl_default =