Commit d66259c0 authored Oct 18, 2023 by Haibo Chen Committed by Greg Kroah-Hartman Oct 25, 2023

gpio: vf610: set value before the direction to avoid a glitch



commit fc363413ef8ea842ae7a99e3caf5465dafdd3a49 upstream.

We found a glitch when configuring the pad as output high. To avoid this
glitch, move the data value setting before direction config in the
function vf610_gpio_direction_output().

Fixes: 659d8a62 ("gpio: vf610: add imx7ulp support")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
[Bartosz: tweak the commit message]
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8670eb71

drivers/gpio/gpio-vf610.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -137,14 +137,14 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
		unsigned long mask = BIT(gpio);
		u32 val;

		vf610_gpio_set(chip, gpio, value);

		if (port->sdata && port->sdata->have_paddr) {
		val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
		val \|= mask;
		vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
		}

		vf610_gpio_set(chip, gpio, value);

		return pinctrl_gpio_direction_output(chip->base + gpio);
		}