Commit d39ee7be authored Nov 03, 2011 by Sebastian Andrzej Siewior Committed by Felipe Balbi Dec 12, 2011

usb: dwc3: gadget: return early in dwc3_cleanup_done_reqs()



This patch avoids the compiler spitting out the following warning:
|drivers/usb/dwc3/gadget.c:1304: warning: 'trb' is used uninitialized \
	in this function

This is only uninitialized if the list of to-cleanup TRBs is empty which
should not be the case because we call this functions once a transfer
completed so it should be on list.

In order to make the warning disappear we return early. This should
never happen and the WARN_ON_ONCE(1) is there in case it happens
so we can investigate what went wrong.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 5bdb1dcc

drivers/usb/dwc3/gadget.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1308,8 +1308,10 @@ static int dwc3_cleanup_done_reqs(struct dwc3 dwc, struct dwc3_ep dep,

		do {
		req = next_request(&dep->req_queued);
		if (!req)
		break;
		if (!req) {
		WARN_ON_ONCE(1);
		return 1;
		}

		dwc3_trb_to_nat(req->trb, &trb);