Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2c23c00 authored by Markus Elfring's avatar Markus Elfring Committed by Trond Myklebust
Browse files

xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc_setup() 

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 662f9a10

net/sunrpc/xprtrdma/backchannel.c

+2 −4
Original line number Diff line number Diff line
@@ -119,11 +119,9 @@ int xprt_rdma_bc_setup(struct rpc_xprt *xprt, unsigned int reqs) 


	for (i = 0; i < (reqs << 1); i++) {

		rqst = kzalloc(sizeof(*rqst), GFP_KERNEL);

		if (!rqst) {

			pr_err("RPC:       %s: Failed to create bc rpc_rqst\n",

			       __func__);

		if (!rqst)

			goto out_free;

		}



		dprintk("RPC:       %s: new rqst %p\n", __func__, rqst);



		rqst->rq_xprt = &r_xprt->rx_xprt;