Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d223b0e7 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: es8238: Fix wrong value references for boolean kctl 



The correct values referred by a boolean control are
value.integer.value[], not value.enumerated.item[].
The former is long while the latter is int, so it's even incompatible
on 64bit architectures.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org>
parent e8371aa0

sound/soc/codecs/es8328.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -120,7 +120,7 @@ static int es8328_get_deemph(struct snd_kcontrol *kcontrol, 
	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

	struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec);

	struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec);





	ucontrol->value.enumerated.item[0] = es8328->deemph;

	ucontrol->value.integer.value[0] = es8328->deemph;

	return 0;

	return 0;

}

}
@@ -129,7 +129,7 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, 
{

{

	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

	struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec);

	struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec);

	int deemph = ucontrol->value.enumerated.item[0];

	int deemph = ucontrol->value.integer.value[0];

	int ret;

	int ret;





	if (deemph > 1)

	if (deemph > 1)