Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d153ba64 authored by Wu Fengguang's avatar Wu Fengguang Committed by Linus Torvalds
Browse files

writeback: do uninterruptible sleep in balance_dirty_pages() 



Using TASK_INTERRUPTIBLE in balance_dirty_pages() seems wrong.  If it's
going to do that then it must break out if signal_pending(), otherwise
it's pretty much guaranteed to degenerate into a busywait loop.  Plus we
*do* want these processes to appear in D state and to contribute to load
average.

So it should be TASK_UNINTERRUPTIBLE.                 -- Andrew Morton

Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f06328d7

mm/page-writeback.c

+1 −1
Original line number Diff line number Diff line
@@ -563,7 +563,7 @@ static void balance_dirty_pages(struct address_space *mapping, 
				break;		/* We've done our duty */

		}

		trace_wbc_balance_dirty_wait(&wbc, bdi);

		__set_current_state(TASK_INTERRUPTIBLE);

		__set_current_state(TASK_UNINTERRUPTIBLE);

		io_schedule_timeout(pause);



		/*