Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d05b3b8a authored by Linus Torvalds's avatar Linus Torvalds Committed by Gerrit - the friendly Code Review server
Browse files

fs/proc: re-factor proc_pid_cmdline_read() a bit 



This is a pure refactoring of the function, preparing for some further
cleanups.  The thing was pretty illegible, and the core functionality
still is, but now the core loop is a bit more isolated from the thing
that goes on around it.

This was "inspired" by the confluence of kworker workqueue name cleanups
by Tejun, currently scheduled for 4.18, and commit 7f7ccc2c ("proc:
do not access cmdline nor environ from file-backed areas").

Change-Id: Ia50851c44fce78de4eb4e6f7b2ef5b91cdda74c1
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Git-commit: e4b4e441
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarPrateek Sood <prsood@codeaurora.org>
parent 0b8903e1

fs/proc/base.c

+39 −25
Original line number Diff line number Diff line
@@ -208,11 +208,9 @@ static int proc_root_link(struct dentry *dentry, struct path *path) 
	return result;

}



static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf,

static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf,

			      size_t _count, loff_t *pos)

{

	struct task_struct *tsk;

	struct mm_struct *mm;

	char *page;

	unsigned long count = _count;

	unsigned long arg_start, arg_end, env_start, env_end;
@@ -221,26 +219,13 @@ static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf, 
	char c;

	ssize_t rv;



	BUG_ON(*pos < 0);



	tsk = get_proc_task(file_inode(file));

	if (!tsk)

		return -ESRCH;

	mm = get_task_mm(tsk);

	put_task_struct(tsk);

	if (!mm)

		return 0;

	/* Check if process spawned far enough to have cmdline. */

	if (!mm->env_end) {

		rv = 0;

		goto out_mmput;

	}

	if (!mm->env_end)

		return 0;



	page = (char *)__get_free_page(GFP_KERNEL);

	if (!page) {

		rv = -ENOMEM;

		goto out_mmput;

	}

	if (!page)

		return -ENOMEM;



	down_read(&mm->mmap_sem);

	arg_start = mm->arg_start;
@@ -368,13 +353,42 @@ static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf, 


out_free_page:

	free_page((unsigned long)page);

out_mmput:

	mmput(mm);

	if (rv > 0)

		*pos += rv;

	return rv;

}



static ssize_t get_task_cmdline(struct task_struct *tsk, char __user *buf,

				size_t count, loff_t *pos)

{

	struct mm_struct *mm;

	ssize_t ret;



	mm = get_task_mm(tsk);

	if (!mm)

		return 0;



	ret = get_mm_cmdline(mm, buf, count, pos);

	mmput(mm);

	return ret;

}



static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf,

				     size_t count, loff_t *pos)

{

	struct task_struct *tsk;

	ssize_t ret;



	BUG_ON(*pos < 0);



	tsk = get_proc_task(file_inode(file));

	if (!tsk)

		return -ESRCH;

	ret = get_task_cmdline(tsk, buf, count, pos);

	put_task_struct(tsk);

	if (ret > 0)

		*pos += ret;

	return ret;

}



static const struct file_operations proc_pid_cmdline_ops = {

	.read	= proc_pid_cmdline_read,

	.llseek	= generic_file_llseek,