Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf590b87 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Daniel Vetter
Browse files

vgaarb: Downgrade userspace-triggerable messages to debug 



To avoid userspace-triggerable dmesg spam, downgrade messages in the sysfs
write parsing code to debug level.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161118141158.32415.71438.stgit@bhelgaas-glaptop.roam.corp.google.com
parent a75d68f6

drivers/gpu/vga/vgaarb.c

+5 −5
Original line number Diff line number Diff line
@@ -1191,7 +1191,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf, 
			}

			pdev = pci_get_domain_bus_and_slot(domain, bus, devfn);

			if (!pdev) {

				pr_err("invalid PCI address %04x:%02x:%02x.%x\n",

				pr_debug("invalid PCI address %04x:%02x:%02x.%x\n",

					 domain, bus, PCI_SLOT(devfn),

					 PCI_FUNC(devfn));

				ret_val = -ENODEV;
@@ -1207,7 +1207,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf, 
		pr_debug("vgadev %p\n", vgadev);

		if (vgadev == NULL) {

			if (pdev) {

				vgaarb_err(&pdev->dev, "not a VGA device\n");

				vgaarb_dbg(&pdev->dev, "not a VGA device\n");

				pci_dev_put(pdev);

			}
@@ -1227,7 +1227,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf, 
			}

		}

		if (i == MAX_USER_CARDS) {

			vgaarb_err(&pdev->dev, "maximum user cards (%d) number reached, ignoring this one!\n",

			vgaarb_dbg(&pdev->dev, "maximum user cards (%d) number reached, ignoring this one!\n",

				MAX_USER_CARDS);

			pci_dev_put(pdev);

			/* XXX: which value to return? */