Commit ce57cba3 authored May 23, 2017 by Dmitry Torokhov Committed by Greg Kroah-Hartman May 25, 2017

firmware: vpd: avoid potential use-after-free when destroying section



We should not free info->key before we remove sysfs attribute that uses
this data as its name.

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7f53de20

drivers/firmware/google/vpd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -158,8 +158,8 @@ static void vpd_section_attrib_destroy(struct vpd_section *sec)
		struct vpd_attrib_info *temp;

		list_for_each_entry_safe(info, temp, &sec->attribs, list) {
		kfree(info->key);
		sysfs_remove_bin_file(sec->kobj, &info->bin_attr);
		kfree(info->key);
		kfree(info);
		}
		}