Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ccf69d5d authored by Sean Anderson's avatar Sean Anderson Committed by Greg Kroah-Hartman
Browse files

usb: ulpi: Move of_node_put to ulpi_dev_release 



commit 092f45b13e51666fe8ecbf2d6cd247aa7e6c1f74 upstream.

Drivers are not unbound from the device when ulpi_unregister_interface
is called. Move of_node-freeing code to ulpi_dev_release which is called
only after all users are gone.

Fixes: ef6a7bcf ("usb: ulpi: Support device discovery via DT")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarSean Anderson <sean.anderson@seco.com>
Link: https://lore.kernel.org/r/20220127190004.1446909-2-sean.anderson@seco.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d8c9812a

drivers/usb/common/ulpi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -135,6 +135,7 @@ static const struct attribute_group *ulpi_dev_attr_groups[] = { 




static void ulpi_dev_release(struct device *dev)

static void ulpi_dev_release(struct device *dev)

{

{

	of_node_put(dev->of_node);

	kfree(to_ulpi_dev(dev));

	kfree(to_ulpi_dev(dev));

}

}
@@ -303,7 +304,6 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface); 
 */

 */

void ulpi_unregister_interface(struct ulpi *ulpi)

void ulpi_unregister_interface(struct ulpi *ulpi)

{

{

	of_node_put(ulpi->dev.of_node);

	device_unregister(&ulpi->dev);

	device_unregister(&ulpi->dev);

}

}

EXPORT_SYMBOL_GPL(ulpi_unregister_interface);

EXPORT_SYMBOL_GPL(ulpi_unregister_interface);