Commit ccb2ca78 authored Jul 26, 2018 by Jia-Ju Bai Committed by Mauro Carvalho Chehab Jul 27, 2018

media: pci: cx23885: Replace mdelay() with msleep() and usleep_range() in altera_ci_slot_reset()



altera_ci_slot_reset() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent da27ef68

drivers/media/pci/cx23885/altera-ci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -346,7 +346,7 @@ static int altera_ci_slot_reset(struct dvb_ca_en50221 *en50221, int slot)
		mutex_unlock(&inter->fpga_mutex);

		for (;;) {
		mdelay(50);
		msleep(50);

		mutex_lock(&inter->fpga_mutex);