Commit cb3b05c3 authored Dec 21, 2015 by Leo Kim Committed by Greg Kroah-Hartman Dec 21, 2015

staging: wilc1000: wilc_init(): fixes inconsistent returns



This patch fixes the warning reported by smatch.
 - wilc_init() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values'

No need to up the sema here since down was not called before get here.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 653bb463

drivers/staging/wilc1000/host_interface.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3873,7 +3873,6 @@ s32 wilc_init(struct net_device dev, struct host_if_drv *hif_drv_handler)
		return result;

		_fail_timer_2:
		up(&hif_drv->sem_cfg_values);
		del_timer_sync(&hif_drv->connect_timer);
		del_timer_sync(&hif_drv->scan_timer);
		kthread_stop(hif_thread_handler);