Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca486a3b authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe
Browse files

IB/qedr: Remove GID add/del dummy routines 



qedr driver's add_gid() and del_gid() callbacks are doing simple
checks which are already done by the ib core before invoking these
callback routines.

Therefore, code is simplified to skip implementing add_gid() and
del_gid() callback functions.

Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 3e64f8d6

drivers/infiniband/hw/qedr/main.c

+0 −3
Original line number Diff line number Diff line
@@ -164,9 +164,6 @@ static void qedr_roce_register_device(struct qedr_dev *dev) 
	dev->ibdev.node_type = RDMA_NODE_IB_CA;

	dev->ibdev.query_gid = qedr_query_gid;



	dev->ibdev.add_gid = qedr_add_gid;

	dev->ibdev.del_gid = qedr_del_gid;



	dev->ibdev.get_port_immutable = qedr_roce_port_immutable;

}

drivers/infiniband/hw/qedr/verbs.c

+0 −31
Original line number Diff line number Diff line
@@ -105,37 +105,6 @@ int qedr_query_gid(struct ib_device *ibdev, u8 port, int index, 
	return rc;

}



int qedr_add_gid(struct ib_device *device, u8 port_num,

		 unsigned int index, const union ib_gid *gid,

		 const struct ib_gid_attr *attr, void **context)

{

	if (!rdma_cap_roce_gid_table(device, port_num))

		return -EINVAL;



	if (port_num > QEDR_MAX_PORT)

		return -EINVAL;



	if (!context)

		return -EINVAL;



	return 0;

}



int qedr_del_gid(struct ib_device *device, u8 port_num,

		 unsigned int index, void **context)

{

	if (!rdma_cap_roce_gid_table(device, port_num))

		return -EINVAL;



	if (port_num > QEDR_MAX_PORT)

		return -EINVAL;



	if (!context)

		return -EINVAL;



	return 0;

}



int qedr_query_device(struct ib_device *ibdev,

		      struct ib_device_attr *attr, struct ib_udata *udata)

{

drivers/infiniband/hw/qedr/verbs.h

+0 −5
Original line number Diff line number Diff line
@@ -48,11 +48,6 @@ struct ib_ucontext *qedr_alloc_ucontext(struct ib_device *, struct ib_udata *); 
int qedr_dealloc_ucontext(struct ib_ucontext *);



int qedr_mmap(struct ib_ucontext *, struct vm_area_struct *vma);

int qedr_del_gid(struct ib_device *device, u8 port_num,

		 unsigned int index, void **context);

int qedr_add_gid(struct ib_device *device, u8 port_num,

		 unsigned int index, const union ib_gid *gid,

		 const struct ib_gid_attr *attr, void **context);

struct ib_pd *qedr_alloc_pd(struct ib_device *,

			    struct ib_ucontext *, struct ib_udata *);

int qedr_dealloc_pd(struct ib_pd *pd);