Commit c900072b authored Dec 08, 2017 by Ian Molton Committed by Kalle Valo Dec 14, 2017

brcmfmac: remove unnecessary call to brcmf_sdiod_set_backplane_window()



All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.

Signed-off-by: Ian Molton <ian@mnementh.co.uk>
[arend: corrected the driver prefix in the subject]
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent a7c3aa15

drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

+0 −5

Original line number	Original line	Diff line number	Diff line
	@@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool write, u32 address,

	dev_kfree_skb(pkt);		dev_kfree_skb(pkt);

	/* Return the window to backplane enumeration space for core access */
	if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
	brcmf_err("FAILED to set window back to 0x%x\n",
	sdiodev->sbwad);

	sdio_release_host(sdiodev->func[1]);		sdio_release_host(sdiodev->func[1]);

	return err;		return err;