Commit c802672c authored Jan 12, 2012 by Tomoya MORINAGA Committed by Felipe Balbi Jan 24, 2012

usb: gadget: pch_udc: Fix wrong return value



ISSUE:
If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.

CAUSE:
If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent c50a3bff

drivers/usb/gadget/pch_udc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2915,8 +2915,10 @@ static int pch_udc_probe(struct pci_dev *pdev,
		}
		pch_udc = dev;
		/* initialize the hardware */
		if (pch_udc_pcd_init(dev))
		if (pch_udc_pcd_init(dev)) {
		retval = -ENODEV;
		goto finished;
		}
		if (request_irq(pdev->irq, pch_udc_isr, IRQF_SHARED, KBUILD_MODNAME,
		dev)) {
		dev_err(&pdev->dev, "%s: request_irq(%d) fail\n", __func__,