Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c51e3a4f authored by Dan Carpenter's avatar Dan Carpenter Committed by Christoph Hellwig
Browse files

mpt2sas: issue_reset is uninitialized 



The "issue_reset" variable can be used uninitialized.  It should be set
to false at the start.

Also I cleaned up the types by using bool.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 2195d969

drivers/scsi/mpt2sas/mpt2sas_base.c

+4 −4
Original line number Diff line number Diff line
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc, 
	u16 smid;

	u32 ioc_state;

	unsigned long timeleft;

	u8 issue_reset;

	bool issue_reset = false;

	int rc;

	void *request;

	u16 wait_state_count;
@@ -3300,7 +3300,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc, 
		_debug_dump_mf(mpi_request,

		    sizeof(Mpi2SasIoUnitControlRequest_t)/4);

		if (!(ioc->base_cmds.status & MPT2_CMD_RESET))

			issue_reset = 1;

			issue_reset = true;

		goto issue_host_reset;

	}

	if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
@@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc, 
	u16 smid;

	u32 ioc_state;

	unsigned long timeleft;

	u8 issue_reset;

	bool issue_reset = false;

	int rc;

	void *request;

	u16 wait_state_count;
@@ -3398,7 +3398,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc, 
		_debug_dump_mf(mpi_request,

		    sizeof(Mpi2SepRequest_t)/4);

		if (!(ioc->base_cmds.status & MPT2_CMD_RESET))

			issue_reset = 1;

			issue_reset = true;

		goto issue_host_reset;

	}

	if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)