Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c46309c7 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

bnx2x: Correct logic for pvid configuration. 



Commit 05cc5a39 ("bnx2x: add vlan filtering offload") has introduced
an incorrect logic for checking whether pvid should be configured for
a vf, causing the hypervisor driver to send unneeded ramrods for all of
the vfs each time a pvid has changed.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarAriel Elior <Ariel.Elior@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5510b3c2

drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

+1 −1
Original line number Diff line number Diff line
@@ -2528,7 +2528,7 @@ void bnx2x_pf_set_vfs_vlan(struct bnx2x *bp) 
	DP(BNX2X_MSG_IOV, "configuring vlan for VFs from sp-task\n");

	for_each_vf(bp, vfidx) {

		bulletin = BP_VF_BULLETIN(bp, vfidx);

		if (bulletin->valid_bitmap & VLAN_VALID)

		if (bulletin->valid_bitmap & (1 << VLAN_VALID))

			bnx2x_set_vf_vlan(bp->dev, vfidx, bulletin->vlan, 0);

	}

}