Commit c2a3072e authored Feb 17, 2009 by Kenji Kaneshige Committed by Jesse Barnes Mar 20, 2009

PCI: fix wrong assumption in pci_get_interrupt_pin



Current pci_get_interrupt_pin() seems to have an assumption that
pci_bus->self is NULL on the root pci bus. But it might not be true on
some platforms. Because of this wrong assumption, current
pci_get_interrupt_pin() might cause endless loop. We must check
pci_bus->parent instead.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent f92d4e29

drivers/pci/pci.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1484,7 +1484,7 @@ pci_get_interrupt_pin(struct pci_dev dev, struct pci_dev *bridge)
	if (!pin)		if (!pin)
	return -1;		return -1;

	while (dev->bus->self) {		while (dev->bus->parent) {
	pin = pci_swizzle_interrupt_pin(dev, pin);		pin = pci_swizzle_interrupt_pin(dev, pin);
	dev = dev->bus->self;		dev = dev->bus->self;
	}		}