Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0ef079c authored by Florian Westphal's avatar Florian Westphal Committed by David S. Miller
Browse files

netdevice: shrink size of struct netdev_queue 



- trans_timeout is incremented when tx queue timed out (tx watchdog).
- tx_maxrate is set via sysfs

Moving tx_maxrate to read-mostly part shrinks the struct by 64 bytes.
While at it, also move trans_timeout (it is out-of-place in the
'write-mostly' part).

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Acked-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e8194d4f

include/linux/netdevice.h

+6 −7
Original line number Diff line number Diff line
@@ -569,6 +569,12 @@ struct netdev_queue { 
#if defined(CONFIG_XPS) && defined(CONFIG_NUMA)

	int			numa_node;

#endif

	unsigned long		tx_maxrate;

	/*

	 * Number of TX timeouts for this queue

	 * (/sys/class/net/DEV/Q/trans_timeout)

	 */

	unsigned long		trans_timeout;

/*

 * write-mostly part

 */
@@ -579,18 +585,11 @@ struct netdev_queue { 
	 */

	unsigned long		trans_start;



	/*

	 * Number of TX timeouts for this queue

	 * (/sys/class/net/DEV/Q/trans_timeout)

	 */

	unsigned long		trans_timeout;



	unsigned long		state;



#ifdef CONFIG_BQL

	struct dql		dql;

#endif

	unsigned long		tx_maxrate;

} ____cacheline_aligned_in_smp;



static inline int netdev_queue_numa_node_read(const struct netdev_queue *q)