Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c090959b authored by Johan Hovold's avatar Johan Hovold Committed by Arnd Bergmann
Browse files

bus: vexpress-config: fix device reference leak



Make sure to drop the reference to the parent device taken by
class_find_device() after populating the bus.

Fixes: 3b9334ac ("mfd: vexpress: Convert custom func API to regmap")
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 920f8bf7
Loading
Loading
Loading
Loading
+6 −1
Original line number Diff line number Diff line
@@ -171,6 +171,7 @@ static int vexpress_config_populate(struct device_node *node)
{
	struct device_node *bridge;
	struct device *parent;
	int ret;

	bridge = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
	if (!bridge)
@@ -182,7 +183,11 @@ static int vexpress_config_populate(struct device_node *node)
	if (WARN_ON(!parent))
		return -ENODEV;

	return of_platform_populate(node, NULL, NULL, parent);
	ret = of_platform_populate(node, NULL, NULL, parent);

	put_device(parent);

	return ret;
}

static int __init vexpress_config_init(void)