Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bfc978fa authored by Amit Kumar Salecha's avatar Amit Kumar Salecha Committed by David S. Miller
Browse files

qlcnic: fix pci resource leak 



pci_get_domain_bus_and_slot: caller must decrement the
reference count by calling pci_dev_put().

Signed-off-by: default avatarAmit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4a1745fc

drivers/net/qlcnic/qlcnic_main.c

+6 −1
Original line number Diff line number Diff line
@@ -2695,10 +2695,15 @@ static int qlcnic_is_first_func(struct pci_dev *pdev) 
		oth_pdev = pci_get_domain_bus_and_slot(pci_domain_nr

			(pdev->bus), pdev->bus->number,

			PCI_DEVFN(PCI_SLOT(pdev->devfn), val));

		if (!oth_pdev)

			continue;



		if (oth_pdev && (oth_pdev->current_state != PCI_D3cold))

		if (oth_pdev->current_state != PCI_D3cold) {

			pci_dev_put(oth_pdev);

			return 0;

		}

		pci_dev_put(oth_pdev);

	}

	return 1;

}