Commit be233b75 authored May 30, 2020 by Yang Yingliang Committed by Greg Kroah-Hartman Jun 10, 2020

devinet: fix memleak in inetdev_init()



[ Upstream commit 1b49cd71b52403822731dc9f283185d1da355f97 ]

When devinet_sysctl_register() failed, the memory allocated
in neigh_parms_alloc() should be freed.

Fixes: 20e61da7 ("ipv4: fail early when creating netdev named all or default")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 106fa147

net/ipv4/devinet.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -269,6 +269,7 @@ static struct in_device inetdev_init(struct net_device dev)
		err = devinet_sysctl_register(in_dev);
		if (err) {
		in_dev->dead = 1;
		neigh_parms_release(&arp_tbl, in_dev->arp_parms);
		in_dev_put(in_dev);
		in_dev = NULL;
		goto out;