Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdb2c74d authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: ad193x: Don't power down DAC in CODEC probe 



The DAC powerdown bit is managed by DAPM. Manually powering down the DAC in
the CODEC probe function may cause unnecessary power state transitions which
can lead to click and pop noises.

So leave the DAC powerdown bit in its default poweron-reset state and let
DAPM do all the management.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 97bf6af1

sound/soc/codecs/ad193x.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -333,8 +333,8 @@ static int ad193x_codec_probe(struct snd_soc_codec *codec) 
	regmap_write(ad193x->regmap, AD193X_DAC_CHNL_MUTE, 0x0);

	regmap_write(ad193x->regmap, AD193X_DAC_CHNL_MUTE, 0x0);

	/* de-emphasis: 48kHz, powedown dac */

	/* de-emphasis: 48kHz, powedown dac */

	regmap_write(ad193x->regmap, AD193X_DAC_CTRL2, 0x1A);

	regmap_write(ad193x->regmap, AD193X_DAC_CTRL2, 0x1A);

	/* powerdown dac, dac in tdm mode */

	/* dac in tdm mode */

	regmap_write(ad193x->regmap, AD193X_DAC_CTRL0, 0x41);

	regmap_write(ad193x->regmap, AD193X_DAC_CTRL0, 0x40);

	/* high-pass filter enable */

	/* high-pass filter enable */

	regmap_write(ad193x->regmap, AD193X_ADC_CTRL0, 0x3);

	regmap_write(ad193x->regmap, AD193X_ADC_CTRL0, 0x3);

	/* sata delay=1, adc aux mode */

	/* sata delay=1, adc aux mode */