Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb54be13 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: diasemi: stop validating rtc_time in .read_time 



The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it before returning from the callback.

Acked-by: default avatarSteve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 35a21123

drivers/rtc/rtc-da9052.c

+1 −2
Original line number Diff line number Diff line
@@ -187,8 +187,7 @@ static int da9052_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm) 
			rtc_tm->tm_min  = v[0][1] & DA9052_RTC_MIN;

			rtc_tm->tm_sec  = v[0][0] & DA9052_RTC_SEC;



			ret = rtc_valid_tm(rtc_tm);

			return ret;

			return 0;

		}



		idx = (1-idx);

drivers/rtc/rtc-da9055.c

+1 −1
Original line number Diff line number Diff line
@@ -158,7 +158,7 @@ static int da9055_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm) 
	rtc_tm->tm_min  = v[1] & DA9055_RTC_MIN;

	rtc_tm->tm_sec  = v[0] & DA9055_RTC_SEC;



	return rtc_valid_tm(rtc_tm);

	return 0;

}



static int da9055_rtc_set_time(struct device *dev, struct rtc_time *tm)

drivers/rtc/rtc-da9063.c

+1 −1
Original line number Diff line number Diff line
@@ -256,7 +256,7 @@ static int da9063_rtc_read_time(struct device *dev, struct rtc_time *tm) 
	else

		rtc->rtc_sync = false;



	return rtc_valid_tm(tm);

	return 0;

}



static int da9063_rtc_set_time(struct device *dev, struct rtc_time *tm)