Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb2b4075 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Greg Kroah-Hartman
Browse files

driver core: use *switch* statement in really_probe() 



There are series of comparisons of the 'ret' variable on the failure path of
really_probe(),  so the  *switch* statement  seems  more appropriate there.

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ba61af6f

drivers/base/dd.c

+9 −5
Original line number Diff line number Diff line
@@ -320,21 +320,25 @@ static int really_probe(struct device *dev, struct device_driver *drv) 
	dev->driver = NULL;

	dev_set_drvdata(dev, NULL);



	if (ret == -EPROBE_DEFER) {

	switch (ret) {

	case -EPROBE_DEFER:

		/* Driver requested deferred probing */

		dev_info(dev, "Driver %s requests probe deferral\n", drv->name);

		driver_deferred_probe_add(dev);

		/* Did a trigger occur while probing? Need to re-trigger if yes */

		if (local_trigger_count != atomic_read(&deferred_trigger_count))

			driver_deferred_probe_trigger();

	} else if (ret != -ENODEV && ret != -ENXIO) {

		break;

	case -ENODEV:

	case -ENXIO:

		pr_debug("%s: probe of %s rejects match %d\n",

			 drv->name, dev_name(dev), ret);

		break;

	default:

		/* driver matched but the probe failed */

		printk(KERN_WARNING

		       "%s: probe of %s failed with error %d\n",

		       drv->name, dev_name(dev), ret);

	} else {

		pr_debug("%s: probe of %s rejects match %d\n",

		       drv->name, dev_name(dev), ret);

	}

	/*

	 * Ignore errors returned by ->probe so that the next driver can try