Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bacdc04d authored by Lior David's avatar Lior David Committed by Alexei Avshalom Lazar
Browse files

wil6210: fix return code of wmi_mgmt_tx and wmi_mgmt_tx_ext 



The functions that send management TX frame have 3 possible
results: success and other side acknowledged receive (ACK=1),
success and other side did not acknowledge receive(ACK=0) and
failure to send the frame. The current implementation
incorrectly reports the ACK=0 case as failure.

Change-Id: Iacb3f54252f4d0b663c06b9909cfe43077b783b4
Signed-off-by: default avatarLior David <liord@codeaurora.org>
Signed-off-by: default avatarAlexei Avshalom Lazar <ailizaro@codeaurora.org>
parent 2ff1a14a

drivers/net/wireless/ath/wil6210/cfg80211.c

+6 −1
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2012-2017 Qualcomm Atheros, Inc.

 * Copyright (c) 2018, The Linux Foundation. All rights reserved.

 * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.

 *

 * Permission to use, copy, modify, and/or distribute this software for any

 * purpose with or without fee is hereby granted, provided that the above
@@ -1567,7 +1567,12 @@ int wil_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev, 
			     params->wait);



out:

	/* when the sent packet was not acked by receiver(ACK=0), rc will

	 * be -EAGAIN. In this case this function needs to return success,

	 * the ACK=0 will be reflected in tx_status.

	 */

	tx_status = (rc == 0);

	rc = (rc == -EAGAIN) ? 0 : rc;

	cfg80211_mgmt_tx_status(wdev, cookie ? *cookie : 0, buf, len,

				tx_status, GFP_KERNEL);

drivers/net/wireless/ath/wil6210/wmi.c

+7 −6
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2012-2017 Qualcomm Atheros, Inc.

 * Copyright (c) 2018, The Linux Foundation. All rights reserved.

 * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.

 *

 * Permission to use, copy, modify, and/or distribute this software for any

 * purpose with or without fee is hereby granted, provided that the above
@@ -3685,8 +3685,9 @@ int wmi_mgmt_tx(struct wil6210_vif *vif, const u8 *buf, size_t len) 
	rc = wmi_call(wil, WMI_SW_TX_REQ_CMDID, vif->mid, cmd, total,

		      WMI_SW_TX_COMPLETE_EVENTID, &evt, sizeof(evt), 2000);

	if (!rc && evt.evt.status != WMI_FW_STATUS_SUCCESS) {

		wil_err(wil, "mgmt_tx failed with status %d\n", evt.evt.status);

		rc = -EINVAL;

		wil_dbg_wmi(wil, "mgmt_tx failed with status %d\n",

			    evt.evt.status);

		rc = -EAGAIN;

	}



	kfree(cmd);
@@ -3738,9 +3739,9 @@ int wmi_mgmt_tx_ext(struct wil6210_vif *vif, const u8 *buf, size_t len, 
	rc = wmi_call(wil, WMI_SW_TX_REQ_EXT_CMDID, vif->mid, cmd, total,

		      WMI_SW_TX_COMPLETE_EVENTID, &evt, sizeof(evt), 2000);

	if (!rc && evt.evt.status != WMI_FW_STATUS_SUCCESS) {

		wil_err(wil, "mgmt_tx_ext failed with status %d\n",

		wil_dbg_wmi(wil, "mgmt_tx_ext failed with status %d\n",

			    evt.evt.status);

		rc = -EINVAL;

		rc = -EAGAIN;

	}



	kfree(cmd);