Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b909f12e authored by Arun Kumar Neelakantam's avatar Arun Kumar Neelakantam Committed by Greg Kroah-Hartman
Browse files

rpmsg: glink: Fix reuse intents memory leak issue 



commit b85f6b601407347f5425c4c058d1b7871f5bf4f0 upstream.

Memory allocated for re-usable intents are not freed during channel
cleanup which causes memory leak in system.

Check and free all re-usable memory to avoid memory leak.

Fixes: 933b45da ("rpmsg: glink: Add support for TX intents")
Cc: stable@vger.kernel.org
Acked-By: default avatarChris Lew <clew@codeaurora.org>
Tested-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
Reported-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6c456036

drivers/rpmsg/qcom_glink_native.c

+9 −0
Original line number Diff line number Diff line
@@ -241,10 +241,19 @@ static void qcom_glink_channel_release(struct kref *ref) 
{

	struct glink_channel *channel = container_of(ref, struct glink_channel,

						     refcount);

	struct glink_core_rx_intent *tmp;

	unsigned long flags;

	int iid;



	spin_lock_irqsave(&channel->intent_lock, flags);

	idr_for_each_entry(&channel->liids, tmp, iid) {

		kfree(tmp->data);

		kfree(tmp);

	}

	idr_destroy(&channel->liids);



	idr_for_each_entry(&channel->riids, tmp, iid)

		kfree(tmp);

	idr_destroy(&channel->riids);

	spin_unlock_irqrestore(&channel->intent_lock, flags);