Commit b6d80852 authored Nov 04, 2015 by Johan Hovold Committed by Greg Kroah-Hartman Nov 04, 2015

greybus: es2: fix endpoint requirement check



The current es2 implementation only checks for no IN or OUT bulk
endpoints, but still assumes there are precisely NUM_BULKS of each.

Specifically, urbs could be allocated and initialised to default values,
which amounts to bulk urbs being submitted to the control endpoint.

We should be able to handle any number of endpoints, but for now let's
just require NUM_BULKS of each.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

parent a51e8551

drivers/staging/greybus/es2.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -848,8 +848,7 @@ static int ap_probe(struct usb_interface *interface,
		endpoint->bEndpointAddress);
		}
		}
		if ((bulk_in == 0) \|\|
		(bulk_out == 0)) {
		if (bulk_in != NUM_BULKS \|\| bulk_out != NUM_BULKS) {
		dev_err(&udev->dev, "Not enough endpoints found in device, aborting!\n");
		goto error;
		}