Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6c7347f authored by Gavin Shan's avatar Gavin Shan Committed by Michael Ellerman
Browse files

powerpc/eeh: Remove duplicated check in eeh_dump_pe_log() 



When eeh_dump_pe_log() is only called by eeh_slot_error_detail(),
we already have the check that the PE isn't in PCI config blocked
state in eeh_slot_error_detail(). So we needn't the duplicated
check in eeh_dump_pe_log().

This removes the duplicated check in eeh_dump_pe_log(). No logical
changes introduced.

Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: default avatarAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent eca036ee

arch/powerpc/kernel/eeh.c

+0 −7
Original line number Diff line number Diff line
@@ -268,13 +268,6 @@ static void *eeh_dump_pe_log(void *data, void *flag) 
	struct eeh_dev *edev, *tmp;

	size_t *plen = flag;



	/* If the PE's config space is blocked, 0xFF's will be

	 * returned. It's pointless to collect the log in this

	 * case.

	 */

	if (pe->state & EEH_PE_CFG_BLOCKED)

		return NULL;



	eeh_pe_for_each_dev(pe, edev, tmp)

		*plen += eeh_dump_dev_log(edev, pci_regs_buf + *plen,

					  EEH_PCI_REGS_LOG_LEN - *plen);