Commit b6959a36 authored Oct 26, 2016 by Josh Poimboeuf Committed by Ingo Molnar Oct 27, 2016

x86/unwind: Detect bad stack return address



If __kernel_text_address() doesn't recognize a return address on the
stack, it probably means that it's some generated code which
__kernel_text_address() doesn't know about yet.

Otherwise there's probably some stack corruption.

Either way, warn about it.

Use printk_deferred_once() because the unwinder can be called with the
console lock by lockdep via save_stack_trace().

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/2d897898f324e275943b590d160b55e482bba65f.1477496147.git.jpoimboe@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 0d2b8579

arch/x86/kernel/unwind_frame.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -20,7 +20,15 @@ unsigned long unwind_get_return_address(struct unwind_state *state)
		addr = ftrace_graph_ret_addr(state->task, &state->graph_idx, *addr_p,
		addr_p);

		return __kernel_text_address(addr) ? addr : 0;
		if (!__kernel_text_address(addr)) {
		printk_deferred_once(KERN_WARNING
		"WARNING: unrecognized kernel stack return address %p at %p in %s:%d\n",
		(void *)addr, addr_p, state->task->comm,
		state->task->pid);
		return 0;
		}

		return addr;
		}
		EXPORT_SYMBOL_GPL(unwind_get_return_address);