Commit b5091b55 authored Aug 17, 2014 by Andreea-Cristina Bernat Committed by David S. Miller Aug 22, 2014

bonding: Replace rcu_dereference() with rcu_access_pointer()



This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.

The following Coccinelle semantic patch was used for solving it:
@@
@@

(
 if(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
 ...+>)) {...}
|
 while(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
  ...+>)) {...}
)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 270b4b31

drivers/net/bonding/bond_alb.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1388,7 +1388,7 @@ static int bond_do_alb_xmit(struct sk_buff skb, struct bonding bond,
	}		}

	if (tx_slave && bond_slave_can_tx(tx_slave)) {		if (tx_slave && bond_slave_can_tx(tx_slave)) {
	if (tx_slave != rcu_dereference(bond->curr_active_slave)) {		if (tx_slave != rcu_access_pointer(bond->curr_active_slave)) {
	ether_addr_copy(eth_data->h_source,		ether_addr_copy(eth_data->h_source,
	tx_slave->dev->dev_addr);		tx_slave->dev->dev_addr);
	}		}