Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3495ceb authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Greg Kroah-Hartman
Browse files

staging: speakup: fix memory leak 



speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.

Signed-off-by: default avatarVasiliy Kulikov <segooon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6a564867

drivers/staging/speakup/main.c

+5 −2
Original line number Diff line number Diff line
@@ -2259,8 +2259,11 @@ static int __init speakup_init(void) 
	first_console = kzalloc(sizeof(*first_console), GFP_KERNEL);

	if (!first_console)

		return -ENOMEM;

	if (speakup_kobj_init() < 0)

		return -ENOMEM;

	err = speakup_kobj_init();

	if (err) {

		kfree(first_console);

		return err;

	}



	reset_default_chars();

	reset_default_chartab();