Commit b201e743 authored May 31, 2016 by Tomi Valkeinen Committed by Dave Airlie Jun 01, 2016

drm: add missing drm_mode_set_crtcinfo call



When setting mode via MODE_ID property,
drm_atomic_set_mode_prop_for_crtc() does not call
drm_mode_set_crtcinfo() which possibly causes:

"[drm:drm_calc_timestamping_constants [drm]] *ERROR* crtc 32: Can't
calculate constants, dotclock = 0!"

Whether the error is seen depends on the previous data in state->mode,
as state->mode is not cleared when setting new mode.

This patch adds drm_mode_set_crtcinfo() call to
drm_mode_convert_umode(), which is called in both legacy and atomic
paths. This should be fine as there's no reason to call
drm_mode_convert_umode() without also setting the crtc related fields.

drm_mode_set_crtcinfo() is removed from the legacy drm_mode_setcrtc() as
that is no longer needed.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Dave Airlie <airlied@redhat.com>

parent 1a695a90

drivers/gpu/drm/drm_crtc.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2821,8 +2821,6 @@ int drm_mode_setcrtc(struct drm_device dev, void data,
		goto out;
		}

		drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);

		/*
		* Check whether the primary plane supports the fb pixel format.
		* Drivers not implementing the universal planes API use a

drivers/gpu/drm/drm_modes.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1518,6 +1518,8 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
		if (out->status != MODE_OK)
		goto out;

		drm_mode_set_crtcinfo(out, CRTC_INTERLACE_HALVE_V);

		ret = 0;

		out: