Commit ae5799dc authored Mar 08, 2018 by Paolo Abeni Committed by David S. Miller Mar 08, 2018

ipvlan: properly annotate rx_handler access



The rx_handler field is rcu-protected, but I forgot to use the
proper accessor while refactoring netif_is_ipvlan_port(). Such
function only check the rx_handler value, so it is safe, but we need
to properly read rx_handler via rcu_access_pointer() to avoid sparse
warnings.

Fixes: 1ec54cb4 ("net: unpollute priv_flags space")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a366e300

drivers/net/ipvlan/ipvlan.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -180,7 +180,7 @@ int ipvlan_link_register(struct rtnl_link_ops *ops);

		static inline bool netif_is_ipvlan_port(const struct net_device *dev)
		{
		return dev->rx_handler == ipvlan_handle_frame;
		return rcu_access_pointer(dev->rx_handler) == ipvlan_handle_frame;
		}

		#endif /* __IPVLAN_H */