Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad2ecbdc authored by Nikolay Kuratov's avatar Nikolay Kuratov Committed by Greg Kroah-Hartman
Browse files

vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space() 



[ Upstream commit 60316d7f10b17a7ebb1ead0642fee8710e1560e0 ]

We need to do signed arithmetic if we expect condition
`if (bytes < 0)` to be possible

Found by Linux Verification Center (linuxtesting.org) with SVACE

Fixes: 06a8fc78 ("VSOCK: Introduce virtio_vsock_common.ko")
Signed-off-by: default avatarNikolay Kuratov <kniv@yandex-team.ru>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20231211162317.4116625-1-kniv@yandex-team.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1a455a1d

net/vmw_vsock/virtio_transport_common.c

+1 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static s64 virtio_transport_has_space(struct vsock_sock *vsk) 
	struct virtio_vsock_sock *vvs = vsk->trans;

	s64 bytes;



	bytes = vvs->peer_buf_alloc - (vvs->tx_cnt - vvs->peer_fwd_cnt);

	bytes = (s64)vvs->peer_buf_alloc - (vvs->tx_cnt - vvs->peer_fwd_cnt);

	if (bytes < 0)

		bytes = 0;