Commit a9560029 authored Jan 26, 2017 by Sara Sharon Committed by Luca Coelho Mar 24, 2017

iwlwifi: mvm: fix accessing fw_id_to_mac_id

Access should be by rcu_dereference. Issue was found by sparse.

Fixes: 65e25482 ("iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS")
Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 6be3b6cc

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2401,7 +2401,7 @@ void iwl_mvm_sta_pm_notif(struct iwl_mvm mvm, struct iwl_rx_cmd_buffer rxb)
		return;

		rcu_read_lock();
		sta = mvm->fw_id_to_mac_id[notif->sta_id];
		sta = rcu_dereference(mvm->fw_id_to_mac_id[notif->sta_id]);
		if (WARN_ON(IS_ERR_OR_NULL(sta))) {
		rcu_read_unlock();
		return;