Unverified Commit a9029636 authored Apr 05, 2023 by Soumya Managoli Committed by Michael Bestas Nov 07, 2023

dsp: q6adm: Resolve mem corruption in adm cb



Conversion of negative "num_modules" var value
will result in max possible unsigned int value
and hence can cause mem corruption when accessed.

Resolve this by assigning the same data type
to "num_modules" var as used in the calling fn.

Original-Change-Id: I4c9d7215b9c7345637e1eb3a1992a41fef71c5cb
Signed-off-by: Soumya Managoli <quic_c_smanag@quicinc.com>
Change-Id: I55fd3ea6bf214e3852c58f8dcae9ada4723fa7d8

parent 99e0c6b2

techpack/audio/4.0/dsp/q6adm.c

+2 −1

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0-only
		/*
		* Copyright (c) 2012-2020, The Linux Foundation. All rights reserved.
		* Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
		*/
		#include <linux/module.h>
		#include <linux/slab.h>
		@@ -1523,7 +1524,7 @@ static int32_t adm_callback(struct apr_client_data data, void priv)
		{
		uint32_t *payload;
		int port_idx, copp_idx, idx, client_id;
		int num_modules;
		uint32_t num_modules;
		int ret;

		if (data == NULL) {