Commit a89ff457 authored Dec 15, 2017 by Colin Ian King Committed by Alex Deucher Dec 15, 2017

drm/amd/display: remove redundant null check of array 'data'



The null check on aconnector->base.edid_blob_ptr->data is redundant
since data is an array and can never be null.  Remove it.

Detected by CoverityScan, CID#1460369 ("Array compared against 0")

Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent a7ea6548

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2725,8 +2725,7 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
	};		};
	struct edid *edid;		struct edid *edid;

	if (!aconnector->base.edid_blob_ptr \|\|		if (!aconnector->base.edid_blob_ptr) {
	!aconnector->base.edid_blob_ptr->data) {
	DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",		DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
	aconnector->base.name);		aconnector->base.name);