Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a74cb369 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

net: sched: cls_matchall: no need to call tcf_exts_change for newly allocated struct 



As the head struct was allocated right before mall_set_parms call,
no need to use tcf_exts_change to do atomic change, and we can just
fill-up the unused exts struct directly by tcf_exts_validate.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 94611bff

net/sched/cls_matchall.c

+2 −12
Original line number Diff line number Diff line
@@ -120,27 +120,17 @@ static int mall_set_parms(struct net *net, struct tcf_proto *tp, 
			  unsigned long base, struct nlattr **tb,

			  struct nlattr *est, bool ovr)

{

	struct tcf_exts e;

	int err;



	err = tcf_exts_init(&e, TCA_MATCHALL_ACT, 0);

	if (err)

		return err;

	err = tcf_exts_validate(net, tp, tb, est, &e, ovr);

	err = tcf_exts_validate(net, tp, tb, est, &head->exts, ovr);

	if (err < 0)

		goto errout;

		return err;



	if (tb[TCA_MATCHALL_CLASSID]) {

		head->res.classid = nla_get_u32(tb[TCA_MATCHALL_CLASSID]);

		tcf_bind_filter(tp, &head->res, base);

	}



	tcf_exts_change(tp, &head->exts, &e);



	return 0;

errout:

	tcf_exts_destroy(&e);

	return err;

}



static int mall_change(struct net *net, struct sk_buff *in_skb,