Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5733703 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Fix an endian bug in fcpcmd_is_corrupted() 



[ Upstream commit cbe3fd39 ]

We should first do the le16_to_cpu endian conversion and then apply the
FCP_CMD_LENGTH_MASK mask.

Fixes: 5f35509d ("qla2xxx: Terminate exchange if corrupted")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarQuinn Tran <Quinn.Tran@cavium.com>
Acked-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 254cc00e

drivers/scsi/qla2xxx/qla_target.h

+2 −2
Original line number Diff line number Diff line
@@ -374,7 +374,7 @@ struct atio_from_isp { 
static inline int fcpcmd_is_corrupted(struct atio *atio)

{

	if (atio->entry_type == ATIO_TYPE7 &&

	    (le16_to_cpu(atio->attr_n_length & FCP_CMD_LENGTH_MASK) <

	    ((le16_to_cpu(atio->attr_n_length) & FCP_CMD_LENGTH_MASK) <

	     FCP_CMD_LENGTH_MIN))

		return 1;

	else