Commit a2436b22 authored Oct 30, 2005 by Jayachandran C Committed by Russell King Oct 30, 2005

[SERIAL] remove unneeded code from serial_core.c

This patch fixes an issue reported by Coverity in serial/serial_core.c

Error reported: Variable "&((info)->tty)->flags" tracked as NULL was passed to a
function that dereferences it.

The later statements in the function assumes 'info->tty != NULL', so this
check is not necessary. Probably a 'BUG_ON(info->tty == NULL)' can be added.

Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 9f75e1ef

drivers/serial/serial_core.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -147,7 +147,6 @@ static int uart_startup(struct uart_state *state, int init_hw)
		* once we have successfully opened the port. Also set
		* up the tty->alt_speed kludge
		*/
		if (info->tty)
		set_bit(TTY_IO_ERROR, &info->tty->flags);

		if (port->type == PORT_UNKNOWN)