Commit a0a7ae89 authored Dec 05, 2007 by Andre Detsch Committed by Arnd Bergmann Dec 19, 2007

[POWERPC] cell: safer of_has_vicinity routine



This patch changes the way we check for the existence of
vicinity property in spe device nodes.

The new implementation does not depend on having an initialized
cbe_spu_info[0].spus, and checks for presence of vicinity in all
nodes, not only in the first one.

Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

parent 3ce2f62b

arch/powerpc/platforms/cell/spu_manage.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -411,10 +411,15 @@ static void init_affinity_qs20_harcoded(void)

		static int of_has_vicinity(void)
		{
		struct spu* spu;
		struct device_node *dn;

		spu = list_first_entry(&cbe_spu_info[0].spus, struct spu, cbe_list);
		return of_find_property(spu_devnode(spu), "vicinity", NULL) != NULL;
		for_each_node_by_type(dn, "spe") {
		if (of_find_property(dn, "vicinity", NULL)) {
		of_node_put(dn);
		return 1;
		}
		}
		return 0;
		}

		static struct spu devnode_spu(int cbe, struct device_node dn)