Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit a016b11c authored by Jerome Brunet's avatar Jerome Brunet Committed by Mark Brown
Browse files

ASoC: es7134: check if mclk rate is valid 



For each supported sample rate, the es7134 can work with several
mclk / sample rate ratio. Check if ratio we get is actually OK.

Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5650729f

sound/soc/codecs/es7134.c

+117 −2
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
 * in the file called COPYING.

 */



#include <linux/of_platform.h>

#include <linux/module.h>

#include <sound/soc.h>
@@ -24,6 +25,77 @@ 
 * The everest 7134 is a very simple DA converter with no register

 */



struct es7134_clock_mode {

	unsigned int rate_min;

	unsigned int rate_max;

	unsigned int *mclk_fs;

	unsigned int mclk_fs_num;

};



struct es7134_chip {

	const struct es7134_clock_mode *modes;

	unsigned int mode_num;

};



struct es7134_data {

	unsigned int mclk;

	const struct es7134_chip *chip;

};



static int es7134_check_mclk(struct snd_soc_dai *dai,

			     struct es7134_data *priv,

			     unsigned int rate)

{

	unsigned int mfs = priv->mclk / rate;

	int i, j;



	for (i = 0; i < priv->chip->mode_num; i++) {

		const struct es7134_clock_mode *mode = &priv->chip->modes[i];



		if (rate < mode->rate_min || rate > mode->rate_max)

			continue;



		for (j = 0; j < mode->mclk_fs_num; j++) {

			if (mode->mclk_fs[j] == mfs)

				return 0;

		}



		dev_err(dai->dev, "unsupported mclk_fs %u for rate %u\n",

			mfs, rate);

		return -EINVAL;

	}



	/* should not happen */

	dev_err(dai->dev, "unsupported rate: %u\n", rate);

	return -EINVAL;

}



static int es7134_hw_params(struct snd_pcm_substream *substream,

			    struct snd_pcm_hw_params *params,

			    struct snd_soc_dai *dai)

{

	struct es7134_data *priv = snd_soc_dai_get_drvdata(dai);



	/* mclk has not been provided, assume it is OK */

	if (!priv->mclk)

		return 0;



	return es7134_check_mclk(dai, priv, params_rate(params));

}



static int es7134_set_sysclk(struct snd_soc_dai *dai, int clk_id,

			     unsigned int freq, int dir)

{

	struct es7134_data *priv = snd_soc_dai_get_drvdata(dai);



	if (dir == SND_SOC_CLOCK_IN && clk_id == 0) {

		priv->mclk = freq;

		return 0;

	}



	return -ENOTSUPP;

}



static int es7134_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)

{

	fmt &= (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK |
@@ -40,6 +112,8 @@ static int es7134_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) 


static const struct snd_soc_dai_ops es7134_dai_ops = {

	.set_fmt	= es7134_set_fmt,

	.hw_params	= es7134_hw_params,

	.set_sysclk	= es7134_set_sysclk,

};



static struct snd_soc_dai_driver es7134_dai = {
@@ -62,6 +136,33 @@ static struct snd_soc_dai_driver es7134_dai = { 
	.ops = &es7134_dai_ops,

};



static const struct es7134_clock_mode es7134_modes[] = {

	{

		/* Single speed mode */

		.rate_min = 8000,

		.rate_max = 50000,

		.mclk_fs = (unsigned int[]) { 256, 384, 512, 768, 1024 },

		.mclk_fs_num = 5,

	}, {

		/* Double speed mode */

		.rate_min = 84000,

		.rate_max = 100000,

		.mclk_fs = (unsigned int[]) { 128, 192, 256, 384, 512 },

		.mclk_fs_num = 5,

	}, {

		/* Quad speed mode */

		.rate_min = 167000,

		.rate_max = 192000,

		.mclk_fs = (unsigned int[]) { 128, 192, 256 },

		.mclk_fs_num = 3,

	},

};



static const struct es7134_chip es7134_chip = {

	.modes = es7134_modes,

	.mode_num = ARRAY_SIZE(es7134_modes),

};



static const struct snd_soc_dapm_widget es7134_dapm_widgets[] = {

	SND_SOC_DAPM_OUTPUT("AOUTL"),

	SND_SOC_DAPM_OUTPUT("AOUTR"),
@@ -86,6 +187,20 @@ static const struct snd_soc_component_driver es7134_component_driver = { 


static int es7134_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct es7134_data *priv;



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;

	platform_set_drvdata(pdev, priv);



	priv->chip = of_device_get_match_data(dev);

	if (!priv->chip) {

		dev_err(dev, "failed to match device\n");

		return -ENODEV;

	}



	return devm_snd_soc_register_component(&pdev->dev,

				      &es7134_component_driver,

				      &es7134_dai, 1);
@@ -93,8 +208,8 @@ static int es7134_probe(struct platform_device *pdev) 


#ifdef CONFIG_OF

static const struct of_device_id es7134_ids[] = {

	{ .compatible = "everest,es7134", },

	{ .compatible = "everest,es7144", },

	{ .compatible = "everest,es7134", .data = &es7134_chip },

	{ .compatible = "everest,es7144", .data = &es7134_chip },

	{ }

};

MODULE_DEVICE_TABLE(of, es7134_ids);